Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3] feat: add new api package #1624

Merged
merged 1 commit into from
Mar 7, 2024
Merged

[3] feat: add new api package #1624

merged 1 commit into from
Mar 7, 2024

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Feb 5, 2024

Part of #1622

This PR:

  • adds new StacksNodeApi @stacks/api package, which wraps many individual networking functions, better for discovery and param re-use

Split into multiple PRs for easier reviewing

next
    ↑
feat/next-cleanup-common-files #1622
    ↑
feat/next-add-new-network #1623
    ↑
feat/next-add-api-package this PR 🟢
    ↑
feat/next-update-api-stacking #1625
    ↑
feat/next-update-cli #1626

Copy link

vercel bot commented Feb 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ❌ Failed (Inspect) Mar 7, 2024 3:35pm

@janniks janniks changed the title feat: add new api package [3] feat: add new api package Feb 5, 2024
Copy link
Contributor

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Seems like a good improvement. It's hard to review in the details

@janniks janniks force-pushed the feat/next-add-new-network branch from 628015f to baee6a2 Compare March 7, 2024 15:29
Base automatically changed from feat/next-add-new-network to next March 7, 2024 15:31
@janniks janniks force-pushed the feat/next-add-api-package branch from b335ae8 to 571e86c Compare March 7, 2024 15:34
@janniks janniks merged commit 0ae858c into next Mar 7, 2024
7 of 9 checks passed
@janniks janniks deleted the feat/next-add-api-package branch March 7, 2024 15:40
@janniks janniks restored the feat/next-add-api-package branch March 12, 2024 01:36
@janniks janniks deleted the feat/next-add-api-package branch March 12, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants